-
Notifications
You must be signed in to change notification settings - Fork 19
Add optional style changing to insert/remove using the config on line… #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The ability to do this sounds great. The impl may need a few iterations depending on what not using options does to the API |
|
Ok impl lgtm now. Should even just require a minor bump as most changes are in the private APIs. Please update the changelog and possibly examples in the readme or docs that are affected. |
ce9d98b to
f1d855b
Compare
|
|
|
Awesome, thanks! I'll publish when I'm sitting at a computer the next time and don't just have a phone xD latest next week |
|
@oli-obk Can we get a release of this change? Would it help if I put up a release PR? |
|
I managed to publish, but need to teach my phone how to git push before I can move the changes to github. If you want to bump the version and adjust the changelog, I would be very glad |
|
Oops yanked. It was a breaking change. Shame on me for not using semver checks |
|
Ahh sure enough yep, I opened #29 I hope that helps! |
This adds a way to stylize our diff using the
ContextConfigstruct.The default behavior does not change aside from adding
Option<Style>to the ContextConfig forremoveandinsertoperations.I'll update docs, tests, and changeling if there's appetite for this change.
Thanks!
TODO (check if already done)