[FIX] base/saas~17.0: do not adapt invalid domains #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
diagnoza
force-pushed
the
master-skip_invalid_domains-owi
branch
from
af3b294 to
aa103ec
Compare
Contributor
|
Can you refer to the right version in the commit message? |
We handle the most common cases and as a last resort we call convert_domain_leaf() in order to convert a domain to a valid Python expression. If that fails, we may confidently state that the given domain is invalid, thus we skip its adaptation altogether.
diagnoza
force-pushed
the
master-skip_invalid_domains-owi
branch
from
aa103ec to
5db53df
Compare
aj-fuentes
changed the title
aj-fuentes
approved these changes
May 3, 2024
Contributor
|
@robodoo r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty much a copy of https://github.com/odoo/upgrade/pull/5916 since this file was moved to
upgrade-utilsince then.We handle the most common cases and as a last resort we call
convert_domain_leaf()in order to convert a domain to a valid Python expression. If that fails, we may confidently state that the given domain is invalid, thus we skip its adaptation altogether.