[FIX] package: add swc binaries to optional dependencies #7157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release commit 8c68f3d has been done with Node.js v22.19.0 and NPM v10.9.3. But in the meantime, NPM had an issue that affected the package-lock.json by pruning OS optional dependencies (See npm/cli#7961). The issue has been fixed (npm/cli#8184) in NPM v11.3 but not backported. During the release process, we ran `npm install`, and so the package-lock.json was updated to remove the optional dependencies for swc binaries. Which caused issues for users each time they run `npm install` as they were not present anymore in the package-lock.json. This commit adds the swc binaries to the optional dependencies of this project to avoid them being pruned again in the future. Task: 0 X-original-commit: b1dc674
|
|
|
@pro-odoo @LucasLefevre this PR targets master and is the last of the forward-port chain containing:
To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Sep 17, 2025
Release commit 8c68f3d has been done with Node.js v22.19.0 and NPM v10.9.3. But in the meantime, NPM had an issue that affected the package-lock.json by pruning OS optional dependencies (See npm/cli#7961). The issue has been fixed (npm/cli#8184) in NPM v11.3 but not backported. During the release process, we ran `npm install`, and so the package-lock.json was updated to remove the optional dependencies for swc binaries. Which caused issues for users each time they run `npm install` as they were not present anymore in the package-lock.json. This commit adds the swc binaries to the optional dependencies of this project to avoid them being pruned again in the future. closes #7157 Task: 0 X-original-commit: b1dc674 Signed-off-by: Lucas Lefèvre (lul) <[email protected]> Signed-off-by: Pierre Rousseau (pro) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release commit 8c68f3d has been done with Node.js v22.19.0 and NPM v10.9.3.
But in the meantime, NPM had an issue that affected the package-lock.json by pruning OS optional dependencies (See npm/cli#7961). The issue has been fixed (npm/cli#8184) in NPM v11.3 but not backported.
During the release process, we ran
npm install, and so the package-lock.json was updated to remove the optional dependencies for swc binaries. Which caused issues for users each time they runnpm installas they were not present anymore in the package-lock.json.This commit adds the swc binaries to the optional dependencies of this project to avoid them being pruned again in the future.
Task: 0
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist
Forward-Port-Of: #7153
Forward-Port-Of: #7147