Skip to content

[ADD] Project: New page about visibility and collaboration #14040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

guga-odoo
Copy link

task-4946930

@guga-odoo guga-odoo requested a review from a team July 15, 2025 14:44
@robodoo
Copy link
Collaborator

robodoo commented Jul 15, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team July 15, 2025 14:45
@auva-odoo auva-odoo requested review from auva-odoo and removed request for a team July 18, 2025 07:40
Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work @guga-odoo ! Since this feature is relatively minor and, as I understand it, part of the standard project settings, I’d suggest adding it to the Project Management page (as a sub-section of Configuraiton) rather than creating a new one. My review comments reflect that approach (e.g. we won't need to repeat how to access the project settings) but let's discuss this if you see it differently!

@guga-odoo guga-odoo force-pushed the 18.0-visibility-collaboration-guga branch from d18f43c to 33a8d6d Compare July 23, 2025 09:24
@guga-odoo
Copy link
Author

Hi @auva-odoo ! I have deleted the page I originally created and added the Collaboration and Visibility section on the Project Management page as you suggested. However I haven't added it as a sub category withing the Settings sub-section, but on the same (heading) level as it makes more sense to me considering how we organized the other sub-sections (scheduling activities and top bar). What do you think?

@guga-odoo guga-odoo requested a review from auva-odoo July 23, 2025 09:48
Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @guga-odoo, thank you for the changes @guga-odoo 🙂 ! I only have two super minor comments (and one of them is more of an FYI), besides this one:

Regarding the section's heading, I don’t think it should be an H2; to me, Visibility and collaboration feels like part of the project’s standard setup (as opposed to optional configuration that is dependent on the installation of another app, for example) so it makes more sense under the Configuration heading. Things like Scheduling activities and Top bar seem more about actually working with the project, not configuring it per say. We can discuss this more if you'd like 😉

@auva-odoo auva-odoo force-pushed the 18.0-visibility-collaboration-guga branch from 33a8d6d to 4116148 Compare July 25, 2025 13:51
@xpl-odoo
Copy link
Contributor

@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants