Breaking change in 1.8.0

[ericmorand]

The following change is a breaking change:

https://github.com/octet-stream/form-data-encoder/blame/v1.8.0/lib/FormDataEncoder.ts#L77

It is possible that some other changes brought by this minor update are also breaking changes.

[octet-stream]

This is rather a bug fix for #9, otherwise this method will return NaN if File without known length was discovered, so I had to make this change. In v2 it was also introduced in minor release. This is unusual change in minor, but it was necessary.

[ericmorand]

The commit message is "fix eslint issue". There is no mention about a bug fix. Instead it looks like a cosmetic change. Except if the commit message is misleading.

[octet-stream]

Ah, right, I see now. The release however mentions the change, so it was intentional: https://github.com/octet-stream/form-data-encoder/releases/tag/v1.8.0 the "Backport headers changes"

[ericmorand]

And anyway, this change prevents every project that depends on the library to build with the strict setting of typescript compiler. This is huge.

[octet-stream]

Okay, I can revert this.

[ericmorand]

Thanks. We have fixed the version to 1.7.2. in our own projects, for now - we have a critical product that requires to be built tonight. But it may not be as easy for some other teams. 🙂

[octet-stream]

Sorry I broke your product. The https://github.com/octet-stream/form-data-encoder/releases/tag/v1.9.0 should revert these changes. 1.8.0 will be marked as deprecated. Thanks for reaching me out!

[octet-stream]

Also please consider upgrade to v2 when it is possible, the 1.x will no longer receive updates (except for those things I might broke in 1.8.0)

[ericmorand]

Thank you so much.

We plan on moving to v2. For now our build toolchain doesn't emit an ESM artifact but we will change this in the next few weeks - to be able to benefit from the most recent versions of your fantastic package, and some others that are also moving to ESM-only.

Again, thanks. Much appreciated.

[octet-stream]

I'm gonna close this, hope your issue is resolved.