Skip to content
This repository was archived by the owner on Feb 15, 2022. It is now read-only.

Parameterize internal routes by lang #470

Merged
merged 1 commit into from
Jul 7, 2021
Merged

Parameterize internal routes by lang #470

merged 1 commit into from
Jul 7, 2021

Conversation

rdavison
Copy link
Contributor

@rdavison rdavison commented Jul 5, 2021 •
edited
Loading

Issue: ocaml/ocaml.org#216 and #460

CHANGES

  • Rename InternalUrls to Route
  • Define type Route.t as a polymorphic variant
  • Create Route component which wraps Next.Link

@vercel
Copy link

vercel bot commented Jul 5, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ocaml/v3-ocaml-org/JWDi7yXNsyAAQpPi3MYbvaaZwSfH
✅ Preview: https://v3-ocaml-org-git-rnd1-parameterize-internal-url-ocaml.vercel.app

@rdavison
Copy link
Contributor Author

rdavison commented Jul 7, 2021

Clicked around the Vercel deployment and it looks good to me.

@rdavison rdavison merged commit 4f46be7 into master Jul 7, 2021
@rdavison rdavison deleted the rnd1/parameterize-internal-url branch July 7, 2021 18:54
This was referenced Jul 7, 2021
Closed
Merged
@ghost ghost mentioned this pull request Jul 7, 2021
Open
9 tasks
@rdavison rdavison mentioned this pull request Jul 8, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rdavison