Skip to content
This repository was archived by the owner on Feb 15, 2022. It is now read-only.

Fix key generation in header navigation code #382

Closed
avsm opened this issue May 25, 2021 · 3 comments
Closed

Fix key generation in header navigation code #382

avsm opened this issue May 25, 2021 · 3 comments

Comments

@avsm
Copy link
Member

avsm commented May 25, 2021

See ocaml/ocaml.org#376 (comment) and a followup to #339
@avsm avsm mentioned this issue May 25, 2021
Merged
avsm added a commit that referenced this issue May 25, 2021
@avsm
undo the static key="0" in HeaderNavigation as its the wrong fix
8868737 
Followup issue is #382 to fix this
@ghost
Copy link

ghost commented May 25, 2021

I am happy to take this issue. I will.assign it to myself for now. Jon can assign it to himself if he particularly wants to work on it.

@ghost ghost assigned ghost and unassigned jonludlam May 25, 2021
@ghost
Copy link

ghost commented Jun 10, 2021

This issue will most likely be addressed as part of one of the PR's that break off from #385, so I haven't bothered starting it. Jon also started a branch and found that #385 should suffice.

@ghost ghost added the short-task label Jun 10, 2021
@ghost ghost assigned tmattio and unassigned ghost Jul 24, 2021
@ghost
Copy link

ghost commented Sep 22, 2021

This issue will become irrelevant as the navigation implementation is changed.

@ghost ghost closed this as completed Sep 22, 2021
@ghost ghost removed the short-task label Sep 22, 2021
@ghost ghost unassigned tmattio Sep 22, 2021
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@avsm @jonludlam @tmattio