-
Notifications
You must be signed in to change notification settings - Fork 365
chore: Use Dune package management #3132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
622df60
chore: migrate to using dune package management
sabine b0fcca7
make Dockerfile use Dune Developer Preview to build
sabine de77a3d
update Makefile to use Dune Developer Preview
sabine 3544e64
remove .opam files
sabine c261526
update HACKING.md for dune pkg, CONTRIBUTING.md doesn't need updating
sabine 620267a
attempt to make Playground build with Dune Developer Preview (fails)
sabine 017f2a5
Build playground with dune pkg
Sudha247 59dd5ef
update CI to use Dune Developer Preview
sabine e5af6bd
update scraper workflow to use dev preview
sabine 6e622e2
copy playground cmi files
sabine f1e40ec
update playground gitignore
sabine 95bfd9c
remove opam.locked file
sabine 22a546a
rely on dune.lock
sabine 12ed046
remove obsolete config
sabine 5d6f6ca
build scraper in makefile
sabine a247128
rely on dune.lock
sabine 3a1d3e6
Pin dune pkg to a specific version in the Dockerfile
Sudha247 343d032
update Dockerfile and HACKING.md
Sudha247 dffbaa2
revert accidental playground changes
sabine b0b8c50
Update to use Dune binary
Sudha247 fd507da
Address review comments
Sudha247 3a0eef0
add ocamlformat as a test dependency
Sudha247 2501b76
remove river pin
sabine b693e90
reduce changes to playground dune-project
sabine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,7 @@ | |
!tool/ | ||
!dune | ||
!dune-project | ||
!ocamlorg.opam | ||
!dune-workspace | ||
!tailwind.config.js | ||
!init-cache | ||
!.git |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
# Dune artifacts | ||
_build/ | ||
dune.lock | ||
dev-tools.locks | ||
|
||
# Local OPAM switch | ||
_opam/ | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Replace all ````` by ````bash` in this file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,12 @@ | ||
(lang dune 3.19) | ||
|
||
(repository (name pinned_opam_repository) (url git+https://github.com/ocaml/opam-repository#584630e7a7e27e3cf56158696a3fe94623a0cf4f)) | ||
(repository | ||
(name pinned_opam_repository) | ||
(url git+https://github.com/ocaml/opam-repository#584630e7a7e27e3cf56158696a3fe94623a0cf4f)) | ||
|
||
(repository (name pinned_overlay_repository) (url git+https://github.com/ocaml-dune/opam-overlays#2a9543286ff0e0656058fee5c0da7abc16b8717d)) | ||
|
||
(lock_dir | ||
(repositories pinned_opam_repository pinned_overlay_repository)) | ||
(repositories pinned_opam_repository pinned_overlay_repository) | ||
(version_preference newest) | ||
) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I fully understand this.
Are we attempting to build ocaml.org with a build tool that changes daily?