Add an io_uring probe function #51
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talex5
requested changes
Feb 18, 2022
There was a problem hiding this comment.
I don't think commenting out the strings like this will work; io_uring_opcode_supported only sees the index, not the string.
Also, while this function is useful for Eio at the moment (which can switch to luv if anything is missing), in general users will want to probe individual features themselves. As new calls get added, Eio might want to use them only if available.
So probably we should add the IO_URING_OP_* values to lib/uring/include/discover.ml and expose them in the interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
Uring.probe ()function that checks the kernel's support for the various io_uring operations that we currently use (I think I got all of them). Hopefully this can help with ocaml-multicore/eio#187 and could be used inEio_mainfor Linux to check if we can using the io_uring backend before defaulting to libuv.