Skip to content

click-click #1540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

click-click #1540

wants to merge 1 commit into from

Conversation

Fil
Copy link
Contributor

@Fil Fil commented May 12, 2023

When playing with http://localhost:8008/?test=tipGeoCentroid on the trackpad, I found that, after a first click that unsticks the tip, I want a second click to show the tip for the new location. Currently a pointermove is needed, and clicking did nothing.

@Fil Fil requested a review from mbostock May 12, 2023 06:28
@mbostock
Copy link
Member

mbostock commented May 13, 2023

I have a mild preference to not do this: the current behavior is the same as native tooltips, and if people double-click to dismiss the tick it’ll still work rather than bringing it back or toggling repeatedly as you click. Is it unreasonable to move the pointer if you want a new tip?

@Fil
Copy link
Contributor Author

Fil commented May 14, 2023

OK. Maybe I could try with a more elaborate PR, but then the risk is that it gets too complicated.

@Fil Fil closed this May 14, 2023
@Fil Fil deleted the fil/tip-click-click branch May 14, 2023 01:32
@Fil Fil mentioned this pull request May 24, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants