adopt curl -f to make the data loader fail if curl fails to download #1667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allisonhorst
approved these changes
Sep 17, 2024
Contributor
allisonhorst
left a comment
allisonhorst
left a comment
There was a problem hiding this comment.
Looks good to me. We use curl for the EIA example (in eia-system-points.json.sh). Even though it doesn't actually update with live data, we may want to update with -f there for consistency.
Contributor
Author
|
Note to self: I'll have to re-deploy loader-census and loader-duckdb, since they show the loader code in the pages. EDIT: DONE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
curlis a rare unix utility that does not return an error code > 0 when it fails, unless we use-f(--fail); seems like a best practice we should promote.