Skip to content

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Apr 12, 2024

Capture d’écran 2024-04-12 à 15 47 14

Advantage of the button: it works in the built page.

@Fil Fil requested a review from mbostock April 12, 2024 13:49
@Fil Fil changed the title interactive button interactive react button Apr 12, 2024
@mbostock
Copy link
Member

Advantage of the button: it works in the built page.

What do you mean? The DIV works now, too, both in preview and in build. Did you find a bug?

Base automatically changed from mbostock/fix-node-import-react to main April 12, 2024 15:45
@Fil
Copy link
Contributor Author

Fil commented Apr 12, 2024

No, not a bug; but the main call to action here is "Try changing the background color to x" which you can't do in the build. And the counter is very tiny.

@mbostock
Copy link
Member

This page is going to be completely overhauled in #1216 so I don’t think we should worry too much about what’s here.

@Fil Fil closed this Apr 12, 2024
@Fil Fil deleted the fil/react-button branch April 12, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants