-
Notifications
You must be signed in to change notification settings - Fork 15
Clarify authentication requriements #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PieterKas
wants to merge
14
commits into
main
Choose a base branch
from
PieterKas-patch-3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
85fe0c1
Clarify authentication requriements
PieterKas 2d4cb9b
White spaces and left-over text
PieterKas 4ec5632
Text Clean-up
PieterKas dbde5df
Text clarification
PieterKas 1a5cae7
Fixed references
PieterKas a2ce1ab
Update draft-ietf-oauth-transaction-tokens.md
PieterKas 1a66e11
Clarify reasons and enforce normative langugage
PieterKas dc60946
Update draft-ietf-oauth-transaction-tokens.md
PieterKas f90bfb2
Update draft-ietf-oauth-transaction-tokens.md
PieterKas 62572a8
Update draft-ietf-oauth-transaction-tokens.md
PieterKas c617e53
Update draft-ietf-oauth-transaction-tokens.md
PieterKas 28dce73
Removed "WIMSE" reference
PieterKas 8fd87aa
Update draft-ietf-oauth-transaction-tokens.md
PieterKas abc7fee
Update draft-ietf-oauth-transaction-tokens.md
PieterKas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a "MAY"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to resolve this as the last open comment before merging. For my own eduication, I am curious about the choice of "can" here vs a normative MUST or MAY.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also am curious. If the
actor_token
does not identify the identity of the requesting workload then it seems that its use is not for the purpose of client authentication which was the original reason for including the text at all.