Identify author by email #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
o2sh
reviewed
Oct 8, 2020
src/info.rs
Outdated
| @@ -489,10 +489,13 @@ impl Info { | |||
|
|
|||
| fn get_authors(git_history: &[String], n: usize) -> Vec<(String, usize, usize)> { | |||
| let mut authors = std::collections::HashMap::new(); | |||
| let mut names = std::collections::HashMap::new(); | |||
| let mut total_commits = 0; | |||
| for line in git_history { | |||
| let commit_author = line.split('\t').collect::<Vec<_>>()[1].to_string(); | |||
There was a problem hiding this comment.
This should probably be called commit_author_email
| let mut total_commits = 0; | ||
| for line in git_history { | ||
| let commit_author = line.split('\t').collect::<Vec<_>>()[1].to_string(); | ||
| let author_name = line.split('\t').collect::<Vec<_>>()[2].to_string(); |
There was a problem hiding this comment.
This should probably be called commit_author_name
There was a problem hiding this comment.
Thanks. I think the following variable names are good because of the relationship with the format string of git log.
- %an = author_name
- %ae = author_email
I've renamed commit_author to author_email in c68e021
src/info.rs
Outdated
| @@ -489,10 +489,13 @@ impl Info { | |||
|
|
|||
| fn get_authors(git_history: &[String], n: usize) -> Vec<(String, usize, usize)> { | |||
| let mut authors = std::collections::HashMap::new(); | |||
| let mut names = std::collections::HashMap::new(); | |||
There was a problem hiding this comment.
This should probably be called author_name_by_email
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before
after
