Skip to content

http: req end after close #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

http: req end after close #1

wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Aug 24, 2019 •
edited
Loading

'end' can be emitted after 'close'. This can cause e.g. pipeline to error with a ERR_STREAM_PREMATURE_CLOSE.

Fix missing.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@ronag ronag force-pushed the req-end-after-close branch from 81fd139 to d60458c Compare August 24, 2019 19:01
This was referenced Aug 24, 2019
Closed
Closed
@ronag ronag changed the title Req end after close http: req end after close Aug 24, 2019
@ronag
Copy link
Member Author

ronag commented Aug 24, 2019 •
edited
Loading

@benjamingr test ping 👍?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ronag