fix: file creation in empty folder without root_folder_label

[geril07]

Fixes: #2512

[alex-courtis]

Thank you for your contribution:

Tested OK except there is an issue:

root_folder_label = ":~:s?$?/..?"

• add multiple files
• add multiple folders
• add mix

root_folder_label = false

• add multiple files
• add multiple folders
• add mix

issue:
on empty root node navigates up a directory

[alex-courtis]

I'm not sure we can make this fix here: get_node_at_cursor is used in a great many places and there are assumptions that it will return nil if the tree is empty and root folder hidden.

Could we make this change specifically in the add function?

[geril07]

The main problem in this function which used for all api functions:

local function wrap_node(f)
  return function(node, ...)
    node = node or require("nvim-tree.lib").get_node_at_cursor()
    if node then
      f(node, ...)
    end
  end
end

get_node_at_cursor returns nil and stops execution. in add function handle already exists

function M.fn(node)
  node = node and lib.get_last_group_node(node)
  if not node or node.name == ".." then
    node = {
      absolute_path = core.get_cwd(),
      nodes = core.get_explorer().nodes,
      open = true,
    }
  end

There are few options we can do:

1. Make another wrapper without if node then;
2. Add second param to wrap_node which would be true by default, kind of skip_if_nil, we can add to other api calls if needed to skip or not and it would be look like this:

local function wrap_node(f, skip_if_nil_node)
  return function(node, ...)
    node = node or require("nvim-tree.lib").get_node_at_cursor()
    if skip_if_nil_node or node then
      f(node, ...)
    end
  end
end

[geril07]

@alex-courtis Could you please describe on empty root node navigates up a directory. I guess i have no trouble with it.

[geril07]

@alex-courtis So what do you think about current solution?

[alex-courtis]

Pragmatic and safe.

API is a bit of a mess and adding boolean arguments isn't the best for readability.

Could you please add a specific method, maybe wrap_node_or_nil

[alex-courtis]

Thank you.

[alex-courtis]

Fantastic work, thank you!