Skip to content

feat: notify [NvimTree] prefix is multiline only if the message is multiline #2453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 14, 2023
Merged

feat: notify [NvimTree] prefix is multiline only if the message is multiline #2453

merged 2 commits into from
Oct 14, 2023

Conversation

alex-courtis
Copy link
Member

This was a little annoying:

[NvimTree]
notify.lua added to clipboard.
Press ENTER or type command to continue

@alex-courtis alex-courtis requested a review from Akmadan23 October 8, 2023 00:56
Akmadan23
Akmadan23 approved these changes Oct 8, 2023
View reviewed changes
Copy link
Collaborator

@Akmadan23 Akmadan23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I didn't think about single line messages, this way is really clever.

@alex-courtis alex-courtis merged commit e64a498 into master Oct 14, 2023
@alex-courtis alex-courtis deleted the feat-multiline-title-only-for-multiline-message branch October 14, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akmadan23 Akmadan23 Akmadan23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alex-courtis @Akmadan23