Skip to content

fix(#2191): disregard floating windows when opening window on edit #2209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2023
Merged

fix(#2191): disregard floating windows when opening window on edit #2209

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea6d79c
fix(#2191): disregard floating windows when opening window on edit
alex-courtis May 13, 2023
1874ad5
Merge branch 'master' into 2191-disregard-floating-windows-when-openi…
alex-courtis May 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lua/nvim-tree/actions/node/open-file.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,12 @@ local function open_in_new_window(filename, mode)
return
end

local win_ids = vim.api.nvim_list_wins()
-- non-floating windows
local win_ids = vim.tbl_filter(function(id)
local config = vim.api.nvim_win_get_config(id)
return config and config.relative == ""
end, vim.api.nvim_list_wins())

local create_new_window = #win_ids == 1 -- This implies that the nvim-tree window is the only one
local new_window_side = (view.View.side == "right") and "aboveleft" or "belowright"

Expand Down