fix(#2191): disregard floating windows when opening window on edit

[alex-courtis]

fixes #2191

[TendonT52]

I've noticed that the recent change has caused unexpected behavior in my settings. According to the documentation, CR should initiate nvim-tree-api.node.open.edit(). However, when I press CR, it appears to execute nvim-tree-api.node.open.vertical() instead.

Here is my current configuration for your reference:
I'm using lazy.nvim

return {
  "nvim-tree/nvim-tree.lua",
  keys = {
    { "<leader>e", ":NvimTreeToggle<CR>" }
  },
  commit = "498e8793bbe73ab5235b3ee8f0aee32f5d01649f",
  init = function()
    local theme = require("config.theme")
    theme.highlight("NvimTreeCursorLine", { bg = theme.color.bg.floating.bright })
  end,
  opts = {
    disable_netrw = true,
    hijack_netrw = true,
    view = {
      number = true,
      relativenumber = true,
      float = {
        enable = true,
        quit_on_focus_loss = true,
        open_win_config = function()
          local screen_w = vim.opt.columns:get()
          local screen_h = vim.opt.lines:get() - vim.opt.cmdheight:get()
          local window_w = screen_w * 0.5
          local window_h = screen_h * 0.8
          local window_w_int = math.floor(window_w)
          local window_h_int = math.floor(window_h)
          local center_x = (screen_w - window_w) / 2
          local center_y = ((vim.opt.lines:get() - window_h) / 2)
              - vim.opt.cmdheight:get()
          return {
            border = "",
            relative = "editor",
            style = "minimal",
            row = center_y,
            col = center_x,
            width = window_w_int,
            height = window_h_int,
          }
        end,
      }
    },
    renderer = {
      add_trailing = false,
      group_empty = false,
      highlight_git = false,
      full_name = false,
      highlight_opened_files = "none",
      highlight_modified = "none",
      root_folder_label = ":~:s?$?/..?",
      indent_width = 4,
      indent_markers = {
        enable = false,
        inline_arrows = true,
        icons = {
          corner = "└",
          edge = "│",
          item = "│",
          bottom = "─",
          none = " ",
        },
      },
      icons = {
        webdev_colors = true,
        git_placement = "before",
        modified_placement = "after",
        padding = " ",
        symlink_arrow = " ➛ ",
        show = {
          file = true,
          folder = true,
          folder_arrow = true,
          git = false,
          modified = true,
        },
      },
      special_files = { "Cargo.toml", "Makefile", "README.md", "readme.md" },
      symlink_destination = true,
    },
  },
  config = function(_, opts)
    require("nvim-tree").setup(opts)
  end
}

I hope this issue can be resolved soon. Thank you.

[alex-courtis]

I've noticed that the recent change has caused unexpected behavior in my settings. According to the documentation, CR should initiate nvim-tree-api.node.open.edit(). However, when I press CR, it appears to execute nvim-tree-api.node.open.vertical() instead.

I did not test floating windows. I'll see if I can come up with a fix for you to test.

[alex-courtis]

@TendonT52 please see #2212