Skip to content

fix(#1716): focus file/directory when created in a sub-directory, don't dispatch FolderCreated on file creation #1722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 5, 2022

Conversation

alex-courtis
Copy link
Member

fixes #1716

Synchronous refresh is always performed on creation. Node is found following create/refresh.

@@ -101,22 +100,14 @@ function M.fn(node)
is_error = true
break
end
events._dispatch_folder_created(path_to_create)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated bug

@alex-courtis
Copy link
Member Author

Not working for the case of a closed node that was previously opened.

@alex-courtis
Copy link
Member Author

Tested OK: #1716 (comment)

@alex-courtis alex-courtis merged commit bdc4ec6 into master Nov 5, 2022
alex-courtis added a commit that referenced this pull request Nov 6, 2022
…ory, don't dispatch FolderCreated on file creation (#1722)"

This reverts commit bdc4ec6.
@alex-courtis alex-courtis deleted the 1716-focus-file-dir-on-creation branch December 16, 2022 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cursor does not focus on file created when creating file with nested directory
1 participant