feat(watcher): fs_poll -> fs_event, destroy nodes/watchers #1431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-courtis
commented
Jul 17, 2022
| @@ -46,12 +46,13 @@ function M.create_watcher(absolute_path) | |||
| end | |||
|
|
|||
| log.line("watcher", "node start '%s'", absolute_path) | |||
| Watcher.new { | |||
| return Watcher.new { | |||
alex-courtis
commented
Jul 17, 2022
| @@ -29,8 +29,8 @@ function M.reload_project(project_root, path) | |||
| return | |||
| end | |||
|
|
|||
| if path and not path:match("^" .. project_root) then | |||
| path = nil | |||
| if path and path:find(project_root, 1, true) ~= 1 then | |||
There was a problem hiding this comment.
This was pattern matching the file name 🤦
Resolves #1373 (comment)
alex-courtis
commented
Jul 17, 2022
| stat = false, | ||
| -- recursive is not functional in neovim's libuv implementation | ||
| recursive = false, | ||
| } |
There was a problem hiding this comment.
Put this in for documentation purposes.
kyazdani42
approved these changes
Jul 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires #1430
Back to fs_event, as we now have thread safe and queued debouncing.
Watchers are destroyed via node destruction.
I'd like to make nodes into a proper class, however I'll do that in a later PR.
node_destroywill do for now.Tested a variety of git projects; tmpfs events are now properly fired 🎩