fix(diagnostics): throttle sequential CocDiagnostics updates, make debouncer safe and sequential #1430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-courtis
commented
Jul 17, 2022
| ---@param context string identifies the callback to debounce | ||
| ---@param timeout number ms to wait | ||
| ---@param callback function to execute on completion | ||
| function M.debounce(context, timeout, callback) | ||
| if M.debouncers[context] then | ||
| pcall(uv.close, M.debouncers[context]) | ||
| -- all execution here is done in a synchronous context; no thread safety required |
There was a problem hiding this comment.
tested exhaustively using vim.is_thread()
alex-courtis
commented
Jul 17, 2022
| M.debouncers[context] = nil | ||
| local timer = uv.new_timer() | ||
| debouncer.timer = timer | ||
| timer:start(timeout, 0, function() |
There was a problem hiding this comment.
This is the key change: perform all our control operations in the direct callback instead of during scheduled execution.
alex-courtis
commented
Jul 17, 2022
| timer:stop() | ||
| end | ||
| if not timer:is_closing() then | ||
| timer:close() |
There was a problem hiding this comment.
Manual reference count handling was not necessary; libuv will clear the last reference on handle close.
alex-courtis
changed the title
alex-courtis
changed the title
alex-courtis
commented
Jul 17, 2022
| @@ -138,10 +138,6 @@ function M.load_project_status(cwd) | |||
| reload_tree_at(opts.project_root) | |||
| end) | |||
| end, | |||
| on_event0 = function() | |||
There was a problem hiding this comment.
I must have left this in when testing.
alex-courtis
commented
Jul 17, 2022
| @@ -888,6 +894,10 @@ Configuration for diagnostic logging. | |||
| File copy and paste actions. | |||
| Type: `boolean`, Default: `false` | |||
|
|
|||
| *nvim-tree.log.types.dev* | |||
There was a problem hiding this comment.
I keep needing a "clean" log context that doesn't get removed by validate_options. Feel free to remove.
kyazdani42
approved these changes
Jul 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1317
This took way too long...
2 could be optional, however it suits all our current use cases including git "threads". We can add an option later if we need it.
Tested:
rm .git/touched* builddefs/touched* docs/touched* ; for i in $(seq 1 200); do touch .git/touched$i; touch builddefs/touched$i; touch docs/touched$i; doneDid not test LSP; COC testing should be sufficient.