fix(explorer): reload executable stat
#1427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyazdani42
reviewed
Jul 16, 2022
lua/nvim-tree/explorer/reload.lua
Outdated
| end | ||
| local n = nodes_by_path[abs] | ||
| n.executable = builders.is_executable(abs, n.extension) |
There was a problem hiding this comment.
check if n exists first please to make sure that this won't crash.
There was a problem hiding this comment.
I did. But I removed it before I created PR because I thought line 49 already covered the case.
What do you think?
There was a problem hiding this comment.
indeed but it still might not go into the conditionals, so make the check again :)
lua/nvim-tree/explorer/reload.lua
Outdated
| @@ -62,7 +62,10 @@ function M.reload(node, status) | |||
| table.insert(node.nodes, link) | |||
| end | |||
| end | |||
|
|
|||
alex-courtis
approved these changes
Jul 17, 2022
There was a problem hiding this comment.
Tested OK after refreshing. Consistent with other operations e.g. rename.
Will work automatically after #1431
Almo7aya
pushed a commit
to Almo7aya/nvim-tree.lua
that referenced
this pull request
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
NvimTreeRefreshcommand didn't refreshexecutablefield of thenode.Step to reproduce:
nvim-treeby:NvimTreeOpenchmodcommand:NvimTreeRefresh