Skip to content

Multi Instance: Refactor: nvim-tree.marks #2830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alex-courtis opened this issue Jul 13, 2024 · 0 comments · Fixed by #2838 or #2873
Closed

Multi Instance: Refactor: nvim-tree.marks #2830

alex-courtis opened this issue Jul 13, 2024 · 0 comments · Fixed by #2838 or #2873
Assignees
@alex-courtis
Labels
PR please nvim-tree team does not have the bandwidth to implement; a PR will be gratefully appreciated
Milestone
Multi Instance - ...

Comments

@alex-courtis
Copy link
Member

alex-courtis commented Jul 13, 2024 •
edited
Loading

nvim-tree.marks is a stateful singleton. Make it an instantiable class owned by Explorer.

All usages must go through the TreeExplorer singleton.
@alex-courtis alex-courtis changed the title Multi Instance nvim-tree.marks Refactor: Multi Instance nvim-tree.marks Jul 13, 2024
@alex-courtis alex-courtis added bug Something isn't working and removed bug Something isn't working labels Jul 13, 2024
@alex-courtis alex-courtis changed the title Refactor: Multi Instance nvim-tree.marks Multi Instance: Refactor: nvim-tree.marks Jul 13, 2024
@alex-courtis alex-courtis added the PR please nvim-tree team does not have the bandwidth to implement; a PR will be gratefully appreciated label Jul 13, 2024
@alex-courtis alex-courtis moved this from Ready to In progress in Multiple Instances Jul 13, 2024
@alex-courtis alex-courtis self-assigned this Jul 13, 2024
@alex-courtis alex-courtis mentioned this issue Jul 14, 2024
Merged
@alex-courtis alex-courtis moved this from In progress to In review in Multiple Instances Jul 14, 2024
alex-courtis added a commit that referenced this issue Jul 21, 2024
@alex-courtis
refactor(#2830): multi instance nvim-tree.marks (#2838)
4e396b2 
refactor(#2380): multi instance nvim-tree.marks
@github-project-automation github-project-automation bot moved this from In review to Done in Multiple Instances Jul 21, 2024
alex-courtis added a commit that referenced this issue Aug 17, 2024
@alex-courtis
refactor(#2830): multi instance marks
741511a
@alex-courtis alex-courtis mentioned this issue Aug 17, 2024
Closed
alex-courtis added a commit that referenced this issue Aug 18, 2024
@alex-courtis
refactor(#2830): multi instance marks
dce16de
@alex-courtis alex-courtis mentioned this issue Aug 18, 2024
Merged
alex-courtis added a commit that referenced this issue Aug 18, 2024
@alex-courtis
refactor(#2830): multi instance marks
a8c2206
alex-courtis added a commit that referenced this issue Aug 18, 2024
@alex-courtis
refactor(#2830): multi instance marks
2d414ec
alex-courtis added a commit that referenced this issue Aug 25, 2024
@alex-courtis
refactor(#2830): multi instance marks (#2873)
e962e97 
* refactor(#2830): multi instance marks

* refactor(#2830): multi instance marks

* refactor(#2830): multi instance marks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alex-courtis alex-courtis

Labels
PR please nvim-tree team does not have the bandwidth to implement; a PR will be gratefully appreciated
Projects
Multiple Instances
Status: Done
Milestone
Multi Instance - 1 - Refactor
1 participant
@alex-courtis