Update promise.wait to throw an error when timeout reached or interrupted #723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipsenkbeil
added a commit
to chipsenkbeil/org-roam.nvim
that referenced
this pull request
May 6, 2024
…promise documentation
chipsenkbeil
added a commit
to chipsenkbeil/org-roam.nvim
that referenced
this pull request
May 6, 2024
…promise documentation
kristijanhusak
requested changes
May 6, 2024
Co-authored-by: Kristijan Husak <[email protected]>
Good to go :) |
kristijanhusak
approved these changes
May 6, 2024
|
Thanks! |
SlayerOfTheBad
pushed a commit
to SlayerOfTheBad/orgmode
that referenced
this pull request
Aug 16, 2024
…pted (nvim-orgmode#723) * Update promise.wait to throw an error when timeout reached or interrupted * Revert some formatting changes * Fix lint error * Add test to demonstrate functionality * Update lua/orgmode/utils/promise.lua Co-authored-by: Kristijan Husak <[email protected]> --------- Co-authored-by: Kristijan Husak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the comment I made in our main org roam issue, I discovered that
Promise.waitdoes not throw an error when the timeout is reached. Instead, it returnsnil.This can be a problem if you're returning
OrgPromise<nil>, as it misleads the promise as succeeding when in reality it may have not completed yet.This updates
Promise.waitto check the return values fromvim.waitto determine if a value should be returned or if an error should be thrown.