feat: add fast shallow headline parsing for search tools #1006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seflue
force-pushed
the
feature/fast-headline-extraction-for-pickers
branch
from
9953e7a to
d888b34
Compare
Adds get_headlines_shallow() method to avoid expensive lazy loading when search tools need only title/tags/level data across all agenda files.
seflue
force-pushed
the
feature/fast-headline-extraction-for-pickers
branch
from
d888b34 to
5c80417
Compare
Member
|
@seflue did you check if it's actually any faster? Creating headline object does not parse any data from the document. It happens only when requested. |
Contributor
Author
|
@kristijanhusak Thanks for the hint. I wasn't aware of that. Closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
get_headlines_shallow()method that extracts only title/tags/level data without creating fullOrgHeadlineobjects, avoiding expensive lazy loading for search tools.Changes
get_headlines_shallow()method toOrgFile_extract_shallow_headline_data()and_parse_headline_title()helpersChecklist
make test