-
Notifications
You must be signed in to change notification settings - Fork 40.6k
Add <C-u>/<C-d> cmp mapping to scroll cmp docs #750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi.
|
Thanks for the feedback- I was editing the file directly on github, do I need to pull my fork and format in neovim? I just kinda did an eyeball on the tab spacing but things got a bit weird somewhere. |
Hi. I don't mean to be dismissive about this but - So you submitted this PR without ever testing it locally? Please:
Thanks. |
Perhaps worth mentioning, the cmp recommended keymaps for this are:
This is also what was in kickstart before the 2024 rewrite:
|
That seems fine to me, I personally prefer up (u) and down (d) but regardless, I think it's generally useful for newcomers who don't know about cmp scrolling. Will change to use C-b and C-f if that is the consensus. |
Right the keys have similar meanings in standard vim:
So both options seem fine, but since cmp recommendation is with c-b/c-f I think it's best to follow them. |
Since these are cmp recommended, I think it's a good addition to add back in. Thanks! |
I have added control-u and control-d to scroll the auto completion window up and down respectively.
For the average new kickstart user, this will give them the ability to scroll documentation without a mouse and keyboard.
I am fond of reading documentation from the autocomplete window and being able to scroll the window without a mouse is a must have for my setup, I believe it may be the same for many others.