-
Notifications
You must be signed in to change notification settings - Fork 945
docs(mcp): add nuxt ui agent as a mcp tool #5476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Barbapapazes
wants to merge
3
commits into
nuxt:v4
Choose a base branch
from
Barbapapazes:feat/mcp-nuxt-ui-agent
base: v4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
ask_nuxt_ui_agenttool is being removed unconditionally, which prevents the main agent from ever accessing it. The deletion should only occur when handling non-streaming requests from the MCP agent itself.View Details
π Patch Details
Analysis
ask_nuxt_ui_agent tool unconditionally removed, blocking main agent delegation
What fails: The main agent cannot delegate Nuxt UI queries to the specialized Nuxt UI agent because the
ask_nuxt_ui_agenttool is unconditionally deleted before the streaming/non-streaming path check.How to reproduce:
/api/searchendpoint with user query (defaultstream=true)ask_nuxt_ui_agenttool for Nuxt UI questionsResult: Main agent cannot delegate - tool deletion on line 18 removes it before the streaming check, preventing streaming requests from accessing it. Tool is missing from both streaming (
stream=true) and non-streaming (stream=false) paths when it should only be missing from non-streaming requests.Expected: The tool deletion should only occur for non-streaming requests (
stream=false) from the MCP agent itself. Streaming requests should have full access to all MCP tools includingask_nuxt_ui_agentto enable proper delegation. The tool prevents infinite loops only when the MCP agent calls back withstream=false.Fix applied: Moved
delete tools['ask_nuxt_ui_agent']from line 18 (unconditional) into theif (stream === false)block (conditional), so the main agent retains tool access while MCP callbacks are protected from recursion.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, always remove this tool.
When using the MCP, the tool
ask_nuxt_ui_agentis available. This tool will fetch/api/searchthat will connect to the MCP to get tools. In that case, the toolask_nuxt_ui_agentmust be removed.