Skip to content

chore: introduce eslint-plugin-vue-i18n #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025
Merged

Conversation

ubugeeei
Copy link
Collaborator

@ubugeeei ubugeeei commented Apr 8, 2025

Hi dear @antfu,

I believe we recently added i18n support in #217, and there's actually an amazing linter specifically for that purpose.

https://github.com/intlify/eslint-plugin-vue-i18n

This linter can catch raw text in templates as well as missing message keys.

Screenshot 2025-04-11 at 2 09 14 Screenshot 2025-04-11 at 2 09 45

I went ahead and tried introducing it, and while it caught some raw text issues, what do you think about going ahead and fixing those?

If so, I’m happy to help with the work — but if you’d prefer to cover this again on a livestream, then consider this just a suggestion and I’ll leave it to you!

@ubugeeei ubugeeei requested a review from antfu as a code owner April 8, 2025 16:19
@ubugeeei ubugeeei marked this pull request as draft April 8, 2025 16:19
Copy link

netlify bot commented Apr 8, 2025

Deploy Preview for learn-nuxt-com ready!

Name Link
🔨 Latest commit e9bd837
🔍 Latest deploy log https://app.netlify.com/sites/learn-nuxt-com/deploys/67f7fad6e417d800087a5df0
😎 Deploy Preview https://deploy-preview-222--learn-nuxt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

nuxthub-admin bot commented Apr 8, 2025

✅ Deployed learn-nuxt-com

Deployed learn-nuxt-com e9bd837 to preview

🔗 install-eslint-plugin-vue-i1.learn-nuxt-com-3w9.pages.dev
📌 048e3652.learn-nuxt-com-3w9.pages.dev
📱
View QR Code QR code linking to deployment URL.

📋 View deployment logs

@ubugeeei ubugeeei force-pushed the install-eslint-plugin-vue-i18n branch from 48f1ff2 to e9bd837 Compare April 10, 2025 17:07
@ubugeeei ubugeeei changed the title [WIP] chore(deps): install eslint-plugin-vue-i18n chore(deps): install eslint-plugin-vue-i18n Apr 10, 2025
@ubugeeei ubugeeei changed the title chore(deps): install eslint-plugin-vue-i18n chore: install eslint-plugin-vue-i18n Apr 10, 2025
@ubugeeei ubugeeei changed the title chore: install eslint-plugin-vue-i18n chore: introduce eslint-plugin-vue-i18n Apr 10, 2025
@ubugeeei ubugeeei added enhancement New feature or request dependencies Pull requests that update a dependency file labels Apr 10, 2025
@ubugeeei ubugeeei marked this pull request as ready for review April 10, 2025 17:13
@ubugeeei ubugeeei requested a review from yuki-mina as a code owner April 10, 2025 17:13
@antfu antfu merged commit 842b826 into main Apr 11, 2025
7 checks passed
@ubugeeei ubugeeei deleted the install-eslint-plugin-vue-i18n branch April 11, 2025 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants