prism-vnc-proxy-2.0 #17
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed version req.
- Created .env.example template for environment variables - Updated README with environment configuration instructions - Added systemd service configuration for using .env file - Included security best practices for handling credentials - Enhanced troubleshooting section with environment variable debugging - Improved documentation for deployment and configuration This change allows for more secure credential management and easier configuration without modifying the core application code.
- Created .env.example template for environment variables - Updated README with environment configuration instructions - Added systemd service configuration for using .env file - Included security best practices for handling credentials - Enhanced troubleshooting section with environment variable debugging - Improved documentation for deployment and configuration This change allows for more secure credential management and easier configuration without modifying the core application code.
This commit improves the VNC proxy service configuration by: 1. Adding support for loading configuration from a .env file 2. Updating the systemd service file to use environment variables 3. Enhancing documentation with security best practices 4. Adding troubleshooting guidance for environment variable issues 5. Documenting signal handling for graceful shutdown These changes make the service more maintainable by: - Separating configuration from service definition - Making it easier to update credentials without modifying the service file - Improving security by restricting access to sensitive information - Ensuring proper cleanup of resources during service shutdown The implementation uses systemd's EnvironmentFile directive to load variables from .env and passes them as command-line arguments to the Python script, requiring no changes to the application code itself.
feat: Add multiple API routes for VM details endpoint
```
```
Enhanced VNC proxy service with multiple API route support:
- Added Nutanix v3 API route: /api/nutanix/v3/vms/{vm_uuid}
- Added Nutanix v1 API route: /PrismGateway/services/rest/v1/vms/{vm_uuid}
- Added custom API route: /api/vm/{vm_uuid}/details
This enhancement improves compatibility with different Nutanix API clients
and provides flexible routing options for VM details retrieval.
Features: Multiple API endpoint support for better client compatibility
Integration: Works with both v1 and v3 Nutanix API clients
Flexibility: Custom endpoint for simplified VM details access
```
- `prism_vnc_proxy.py` - Added multiple API routes for VM details
- Service starts successfully with new routes
- All existing functionality preserved
- HTTP server responds correctly on port 8080
- VNC proxy functionality remains intact
- New API endpoints ready for VM details requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated code to support: