Skip to content

Conversation

Hofer-Julian
Copy link
Contributor

Looking forward to seeing the expected output of commands in the docs :)

Hofer-Julian added a commit to Hofer-Julian/nushell that referenced this pull request Mar 15, 2023
@Hofer-Julian
Copy link
Contributor Author

I had to manually fix the docs for xml.

You can find the changes here: nushell/nushell#8462

fdncred pushed a commit to nushell/nushell that referenced this pull request Mar 15, 2023
@fdncred
Copy link
Contributor

fdncred commented Mar 15, 2023

@Hofer-Julian I landed your xml fix. Do you want to re-run these to make sure it works? I also noticed that the windows command registry query isn't in the list here.

@Hofer-Julian
Copy link
Contributor Author

@Hofer-Julian I landed your xml fix. Do you want to re-run these to make sure it works?

That would also update the version numbers.
I don't think we want that, right?

I also noticed that the windows command registry query isn't in the list here.

Yes, because I've run the command on a Linux machine.

@fdncred
Copy link
Contributor

fdncred commented Mar 15, 2023

Maybe we can see what @hustcer has to say, he always works on this.

@hustcer
Copy link
Contributor

hustcer commented Mar 15, 2023

Looks good to me, I think we can land it, thanks

@hustcer hustcer merged commit bf2f781 into nushell:main Mar 15, 2023
@fdncred
Copy link
Contributor

fdncred commented Mar 15, 2023

This looks good. I love how the examples show up so nice. Nice work!

However, the next time we run these commands we need to try and make sure that we have all the plugins installed and registered. For example, looking at the help for query web has virtually nothing where the command in the repl looks like this.

query web --help
execute selector query on html/web

Usage:
  > query web {flags}

Flags:
  -h, --help - Display the help message for this command
  -q, --query <String> - selector query
  -m, --as-html - return the query output as html
  -a, --attribute <String> - downselect based on the given attribute
  -t, --as-table <Table> - find table based on column header list
  -i, --inspect - run in inspect mode to provide more information for determining column headers

Examples:
  Retrieve all <header> elements from phoronix.com website
  > http get https://phoronix.com | query web -q 'header'

  Retrieve a html table from Wikipedia and parse it into a nushell table using table headers as guides
  > http get https://en.wikipedia.org/wiki/List_of_cities_in_India_by_population
    | query web -t [Rank City 'Population(2011)[3]' 'Population(2001)' 'State or union territory']

  Pass multiple css selectors to extract several elements within single query, group the query results together and rotate them to create a table
  > http get https://www.nushell.sh | query web -q 'h2, h2 + p' | group 2 | each {rotate --ccw tagline description} | flatten

  Retrieve a specific html attribute instead of the default text
  > http get https://example.org | query web --query a --attribute hre

@Hofer-Julian Hofer-Julian deleted the update-commands-077 branch March 16, 2023 05:46
@Hofer-Julian
Copy link
Contributor Author

Mmmh weird, do I have to register plugins every time I run install_all.sh?

@hustcer
Copy link
Contributor

hustcer commented Mar 16, 2023

The plugins will be registered if you have registered them before

@Hofer-Julian
Copy link
Contributor Author

The plugins will be registered if you have registered them before

Then the problem probably lies somewhere else

ayax79 pushed a commit to ayax79/nushell.github.io that referenced this pull request Jun 26, 2024
Add new crates to the release script and updates the order of existing
crates according to the `nu_deps.nu` script.
ayax79 pushed a commit to ayax79/nushell.github.io that referenced this pull request Jun 26, 2024
This PR is part of porting all old scripts nushell#221 and ports `make_release`
folder
## Summary

### make_release/this_week_in_nu_weekly.nu
This script has already been ported and has received some updates: nushell#433.
So I just removed it
```yaml
from: before_v0.60/make_release/this_week_in_nu_weekly.nu
to: make_release/this_week_in_nu_weekly.nu
functions:
    do-work: make_release/this_week_in_nu_weekly.nu:1:query-week-span
```

### make_release/this_week_in_nu_release.nu

I have ported this, but I'm not sure if we need it because it has
strange name and we have `prs.nu` and `make_release/release-note/`

```yaml
from: before_v0.60/make_release/this_week_in_nu_release.nu
to: make_release/this_week_in_nu_release.nu
functions:
    do-work: make_release/this_week_in_nu_release.nu:1:do-work
```

### make_release/nu_release.nu

This has already been ported to `make_release/nu_release.nu` and has
received new updates nushell#828 so I just removed it

```yaml
from: before_v0.60/make_release/nu_release.nu
to: make_release/nu_release.nu
```

### make_release/gen-js-ext.nu
This has already been moved to `make_release/gen-js-ext.nu` and has
received new updates nushell#621 but not completely ported so I have ported it
- pipeline `for` to `each`
- `$nu.scope.commands` to `scope commands`
- explicit `print`
```yaml
from: before_v0.60/make_release/gen-js-ext.nu
to: make_release/gen-js-ext.nu
functions:
  gen_keywords: make_release/gen-js-ext.nu:1:gen_keywords
  gen_sub_keywords: make_release/gen-js-ext.nu:20:gen_sub_keywords
```

### make_release/gen-ts-ext.nu
I have ported this script
```yaml
from: before_v0.60/make_release/gen-ts-ext.nu
to: make_release/gen-ts-ext.nu
functions:
  gen-ts-cmds-begin: make_release/gen-ts-ext.nu:1:gen-ts-cmds-begin
  gen-ts-cmds: make_release/gen-ts-ext.nu:18:gen-ts-cmds
  gen-ts-subs: make_release/gen-ts-ext.nu:40:gen-ts-subs
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants