-
Notifications
You must be signed in to change notification settings - Fork 527
Fix and extend color documentation #1773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Drop ambiguous hash label - works just fine with only the symbol `#` * Clarify when it is commented out vs may be (hex) value * Drop text table of contents; the website has it's own sidebar table of contents / headline jump list * Fix headline levels - the general color declaration docs were under Table Borders, and hex and full hex were not on the same level * Introduce/Rename main section 'Color Configuration' * Show command to print the current configuration * Add closure declaration format documentation * Drop separators following headlines; other headlines do not have this, they make no logical sense, and they lead to double-separator-lines being rendered on the website Resolves nushell#1503
I made a couple comments above. I'm not sure the documentation covers it well but there's a nuance to coloring and theming and that is, coloring can also be controled by your terminal theme. For named colors like I'm not saying you need to put this in this PR, and I definitely didn't explain it very well, but coloring is kind of weird. |
I think I get what you mean. I'll not cover that in this PR though, it already has multiple concerns, and it's not part of the docs before either. |
Was intended and result is described below.
Thanks for the updates. I found a couple more things that are incomplete. |
Thanks |
#
Resolves #1503