Skip to content

Improve the E2BIG detection #127

@zimbatm

Description

@zimbatm

Is your feature request related to a problem? Please describe.

This is a follow-up on #10 . In ab23c9f I limited the number of arguments to 1024, which is a conservative value that should work across all systems.

Describe the solution you'd like

Implement a mechanism that selects something closer to what is supported in the system. On my machine, getconf ARG_MAX returns 2097152 for example. I think that's the number of bytes total that argv can take, including the \0 separators.

Describe alternatives you've considered

Change the treefmt formatter interface to take the list of files to format from stdin instead. It might be good to do that in the future, but formatters don't generally support that method. I would still be up for allowing to select the interface per formatter.

Additional context

User report:

used to run in a few ms on my test tree now it's ~1s

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions