Skip to content

Update pre-commits #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Update pre-commits #487

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.4.0
rev: f71fa2c1f9cf5cb705f73dffe4b21f7c61470ba9 # frozen: v4.4.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait... why freeze to specific commits? Shouldn't we let these update and make incremental changes as new bugs etc. are found? Usually the bot will do the heavy lifting for us

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just ran $ pre-commit autoupdate --freeze. The bot should do it as well, I normally fix the rev and have the bot update monthly to keep down the noise.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, feel free to configure the bot as you see fit now that it's enabled!

hooks:
- id: trailing-whitespace
- id: end-of-file-fixer
Expand All @@ -17,24 +17,24 @@ repos:
- id: check-added-large-files

- repo: https://github.com/psf/black
rev: 23.3.0
rev: 193ee766ca496871f93621d6b58d57a6564ff81b # frozen: 23.7.0
hooks:
- id: black

- repo: https://github.com/pre-commit/mirrors-prettier
rev: v2.7.1
rev: 672abe14d309fc28817d45b6be25ea976a92222a # frozen: v3.0.2
hooks:
- id: prettier
files: \.(html|md|toml|yml|yaml)
args: [--prose-wrap=preserve]

- repo: https://github.com/adamchainz/blacken-docs
rev: 1.14.0
rev: 960ead214cd1184149d366c6d27ca6c369ce46b6 # frozen: 1.16.0
hooks:
- id: blacken-docs

- repo: https://github.com/asottile/pyupgrade
rev: v3.7.0
rev: b3e813e5d60a472ba815a45d107bbdf106405973 # frozen: v3.10.1
hooks:
- id: pyupgrade
args: [--py38-plus]
Expand Down