Skip to content

Update pre-commits #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Conversation

jarrodmillman
Copy link
Member

No description provided.

@larsoner
Copy link
Collaborator

I just enabled pre-commit.ci for this repo so that hopefully this isn't needed in the future. In the meantime, thanks @jarrodmillman !

@jarrodmillman jarrodmillman merged commit e8d5af5 into numpy:main Aug 17, 2023
@larsoner
Copy link
Collaborator

... looks like it worked:

https://results.pre-commit.ci/run/github/11639513/1692286665.X309Hbw3TWq2shr-Hwn_hA

@@ -3,7 +3,7 @@

repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.4.0
rev: f71fa2c1f9cf5cb705f73dffe4b21f7c61470ba9 # frozen: v4.4.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait... why freeze to specific commits? Shouldn't we let these update and make incremental changes as new bugs etc. are found? Usually the bot will do the heavy lifting for us

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just ran $ pre-commit autoupdate --freeze. The bot should do it as well, I normally fix the rev and have the bot update monthly to keep down the noise.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, feel free to configure the bot as you see fit now that it's enabled!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants