Skip to content

Add pre-commit hook / linter #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 5, 2022
Merged

Add pre-commit hook / linter #374

merged 3 commits into from
Apr 5, 2022

Conversation

jarrodmillman
Copy link
Member

No description provided.

@jarrodmillman jarrodmillman requested a review from rossbar April 5, 2022 16:25
@jarrodmillman jarrodmillman changed the title Lint Add pre-commit hook / linter Apr 5, 2022
rossbar
rossbar approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor of this cleanup - the things the linter caught seem like obvious improvements. No opinion about the yaml formatting, but the changes to the Python source LGTM.

@jarrodmillman jarrodmillman requested a review from larsoner April 5, 2022 17:01
@larsoner larsoner merged commit 032dbc7 into numpy:main Apr 5, 2022
@larsoner
Copy link
Collaborator

larsoner commented Apr 5, 2022

Thanks @jarrodmillman !

@jarrodmillman jarrodmillman added this to the 1.3.0 milestone Apr 25, 2022
@jarrodmillman jarrodmillman deleted the lint branch September 28, 2022 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossbar rossbar rossbar approved these changes

@larsoner larsoner Awaiting requested review from larsoner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jarrodmillman @larsoner @rossbar