Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few updates related to xref
make_xref
test instead of custom one. From looking atgit blame
, it seems the originalnumpydoc_xref_aliases
was replaced withDEFAULT_LINKS
, but this change wasn't applied to the test suite. It's possible this was intentional, but I figured using the default dict made more sense.numpydoc_xref_aliases
config val ininstall.rst
. The description says the default is an empty dict, but the default is actuallyDEFAULT_LINKS
. The current description also makes it seem like the default depends on the intersphinx configuration though it doesn't seem to AFAICT.make_xref
docstring