Skip to content

Update theme #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Update theme #668

merged 1 commit into from
Sep 18, 2023

Conversation

jarrodmillman
Copy link
Member

Brief description of what is fixed or changed

@netlify
Copy link

netlify bot commented Aug 1, 2023

Deploy Preview for numpy-org ready!

Name Link
🔨 Latest commit 4e5732b
🔍 Latest deploy log https://app.netlify.com/sites/numpy-org/deploys/6503430ae047fa0008592591
😎 Deploy Preview https://deploy-preview-668--numpy-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stefanv
Copy link
Contributor

stefanv commented Aug 1, 2023

The alignment of the NumPy title doesn't look quite right to me.
I will take a look at what changed in the theme.

@jarrodmillman
Copy link
Member Author

jarrodmillman commented Aug 18, 2023

@alphapapa It is getting close, but not quite there yet:
2023-08-18T12:28:49,997786884-07:00

@alphapapa
Copy link
Contributor

Thanks, investigating...

alphapapa added a commit to alphapapa/scientific-python-hugo-theme that referenced this pull request Aug 23, 2023
* assets/theme-css/styles.css:
(.flex-column): Add "margin-left: 0.5em;"
(.hero-title): Add "justify-content: center; margin-right: 0.5em;"

Intended to fix overlap issue shown by
<numpy/numpy.org#668 (comment)>.
@alphapapa
Copy link
Contributor

With the change in alphapapa/scientific-python-hugo-theme@30305d4, it now looks like this:
Screenshot_20230823_114800

What's the best way to effect this change here? I suppose I should make a pull request on the scientific-python-hugo-theme repo to merge that change, and then after it's merged, this PR can be updated to point to that new commit, right?

jarrodmillman pushed a commit to scientific-python/scientific-python-hugo-theme that referenced this pull request Aug 23, 2023
* assets/theme-css/styles.css:
(.flex-column): Add "margin-left: 0.5em;"
(.hero-title): Add "justify-content: center; margin-right: 0.5em;"

Intended to fix overlap issue shown by
<numpy/numpy.org#668 (comment)>.
@jarrodmillman jarrodmillman marked this pull request as ready for review August 23, 2023 18:49
@jarrodmillman
Copy link
Member Author

Thanks @alphapapa ! This is ready for review.

@InessaPawson
Copy link
Member

@alphapapa Thank you for working on this!
@jarrodmillman @stefanv What do you think of positioning the black button and the slogan above it further to the right, like in the screenshot below?

numpyorg-CTA-grid

Here is how it would look like without the grid:

numpyorg-CTA

@alphapapa
Copy link
Contributor

@InessaPawson Jarrod asked me to check on this. It looks nice. A few thoughts/questions:

  1. Would you share the CSS changes you made to do that?
  2. Does that change affect the positioning in narrow viewports, e.g. phone-sized, when the div.flex-column element is wrapped to be below the div.hero-title element?
  3. I see that the img.hero-logo element is also smaller and appears like a superscript next to the NumPy text. That looks nice as well, but if that were not also changed, it might affect the div.flex-column position (or its aesthetic appearance with regard to spacing). Do you propose to make this change also?
  4. Also, which browser did you take those screenshots in?

Thanks.

@stefanv
Copy link
Contributor

stefanv commented Sep 15, 2023

I think it would be good to ensure that (a) the logo appears as the smaller "superscript" version and (b) the space between the logo and button/text next to it remains (i.e., similar to how it currently looks on numpy.org).

Most sites seem to have good spacing between the two "columns", but because NumPy's box is so wide, it probably pushes into the logo. Options may be to wrap and stretch the box, or just to force a certain amount of spacing in between.

The logo changing size and position may have been an inadvertent theme change (or, at least, I didn't notice it until now).

@InessaPawson
Copy link
Member

Thank you for working on this, @jarrodmillman ! Let’s merge it now and iterate, if needed, in followup PRs.

@InessaPawson InessaPawson merged commit 268abd1 into numpy:main Sep 18, 2023
@alphapapa
Copy link
Contributor

I think it would be good to ensure that (a) the logo appears as the smaller "superscript" version and (b) the space between the logo and button/text next to it remains (i.e., similar to how it currently looks on numpy.org).

Most sites seem to have good spacing between the two "columns", but because NumPy's box is so wide, it probably pushes into the logo. Options may be to wrap and stretch the box, or just to force a certain amount of spacing in between.

The logo changing size and position may have been an inadvertent theme change (or, at least, I didn't notice it until now).

Tracking in scientific-python/scientific-python-hugo-theme#261

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants