-
-
Notifications
You must be signed in to change notification settings - Fork 120
Update theme #668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update theme #668
Conversation
✅ Deploy Preview for numpy-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The alignment of the NumPy title doesn't look quite right to me. |
@alphapapa It is getting close, but not quite there yet: |
Thanks, investigating... |
* assets/theme-css/styles.css: (.flex-column): Add "margin-left: 0.5em;" (.hero-title): Add "justify-content: center; margin-right: 0.5em;" Intended to fix overlap issue shown by <numpy/numpy.org#668 (comment)>.
With the change in alphapapa/scientific-python-hugo-theme@30305d4, it now looks like this: What's the best way to effect this change here? I suppose I should make a pull request on the scientific-python-hugo-theme repo to merge that change, and then after it's merged, this PR can be updated to point to that new commit, right? |
* assets/theme-css/styles.css: (.flex-column): Add "margin-left: 0.5em;" (.hero-title): Add "justify-content: center; margin-right: 0.5em;" Intended to fix overlap issue shown by <numpy/numpy.org#668 (comment)>.
Thanks @alphapapa ! This is ready for review. |
@alphapapa Thank you for working on this! ![]() Here is how it would look like without the grid: ![]() |
@InessaPawson Jarrod asked me to check on this. It looks nice. A few thoughts/questions:
Thanks. |
cc3112b
to
4e5732b
Compare
I think it would be good to ensure that (a) the logo appears as the smaller "superscript" version and (b) the space between the logo and button/text next to it remains (i.e., similar to how it currently looks on numpy.org). Most sites seem to have good spacing between the two "columns", but because NumPy's box is so wide, it probably pushes into the logo. Options may be to wrap and stretch the box, or just to force a certain amount of spacing in between. The logo changing size and position may have been an inadvertent theme change (or, at least, I didn't notice it until now). |
Thank you for working on this, @jarrodmillman ! Let’s merge it now and iterate, if needed, in followup PRs. |
Tracking in scientific-python/scientific-python-hugo-theme#261 |
Brief description of what is fixed or changed