Compiler Sanitization tests CI #242
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@SwayamInSync it doesn't seem like too many UBSan warnings and I think they're all inside of the quaddtype implementation. I'd probably just fix them. |
Member
Author
|
Right, there were some from NumPy as well, this job only grep on Sure, I'll look over them and resolve |
Member
|
The NumPy ones we can add suppressions for. Or fix them in NumPy 😀. This describes how to use suppression files for TSan, it's the same for the other sanitizers: https://py-free-threading.github.io/thread_sanitizer/#tsan-suppressions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ngoldbaum from NumPy I added both ASAN and UBSAN, for now only UBSAN warnings seems to be there.
The workflow is set to fail only if any warnings are found. Maybe we can more loose it to as fail if only ASAN are found.