Skip to content
This repository was archived by the owner on Jun 10, 2020. It is now read-only.

Conversation

szb0
Copy link
Contributor

@szb0 szb0 commented Sep 17, 2019

I added a couple of commonly used array creation routines (ones and zeros).

One thing that I would imagine is out of scope of this PR and likely out of scope of this project is pythons treatment of bool as a subclass of int. This means with _ShapeLike we can have something like np.zeros(False) pass the analysis, while numpy at runtime raises a TypeError.

Sahil Zubair added 2 commits September 17, 2019 00:14
too few args

formatting

new line
@szb0 szb0 changed the title Array Creation Routines: Zeros, Ones Array Creation Routines: zeros and ones Sep 17, 2019
@shoyer
Copy link
Member

shoyer commented Sep 19, 2019

This looks great, thank you!

@shoyer shoyer merged commit be9a479 into numpy:master Sep 19, 2019
@szb0 szb0 deleted the zeros-ones branch October 8, 2019 00:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants