This repository was archived by the owner on Jun 10, 2020. It is now read-only.
Added typing information for datetime64, timedelta64 #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedder
commented
Jul 9, 2019
| @@ -393,14 +394,39 @@ class number(generic): | |||
|
|
|||
| class bool_(_real_generic): ... | |||
| class object_(generic): ... | |||
| class datetime64(_real_generic): ... | |||
|
|
|||
| class datetime64: | |||
There was a problem hiding this comment.
Motivation behind removing inheritance of _real_generic: inheritance allowed code like this to pass mypy
np.timedelta64(0) - np.datetime64(0, 'D')
bedder
commented
Jul 9, 2019
| @@ -50,14 +51,14 @@ def test_fail(path, py2_arg): | |||
| with open(path) as fin: | |||
| lines = fin.readlines() | |||
|
|
|||
| errors = {} | |||
| errors = defaultdict(lambda: "") | |||
There was a problem hiding this comment.
The previous iteration of the code didn't work too well when we had multi-line error messages (e.g. with overload matching errors), as it would just overwrite the error messages.
|
Thanks @bedder! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions to support the
datetime64andtimedelta64classes, as described here.