Skip to content

applications: nrf_desktop: align dfu config channel with nRF54H IronSide #24865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

applications: nrf_desktop: align dfu config channel with nRF54H IronSide #24865

wants to merge 1 commit into from

Conversation

kapi-no
Copy link
Contributor

@kapi-no kapi-no commented Oct 3, 2025

Adapted the DFU module over the Configuration channel in the nRF Desktop application so that it can work with the new nRF54H20 DFU architecture.

Enabled support for the DFU module over the Configuration channel in all configurations of the nrf54h20dk/nrf54h20/cpuapp board target.

Ref: NCSDK-34151

@kapi-no
applications: nrf_desktop: align dfu config channel with nRF54H IronSide
f821943 
Adapted the DFU module over the Configuration channel in the nRF Desktop
application so that it can work with the new nRF54H20 DFU architecture.

Enabled support for the DFU module over the Configuration channel in
all configurations of the nrf54h20dk/nrf54h20/cpuapp board target.

Ref: NCSDK-34151

Signed-off-by: Kamil Piszczek <[email protected]>
@kapi-no kapi-no requested a review from a team as a code owner October 3, 2025 12:47
@NordicBuilder NordicBuilder added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 3, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 3, 2025 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 1

Inputs:

Sources:

sdk-nrf: PR head: f821943f68c6e0b98855de48ab2d800300cc0072

more details

sdk-nrf:

PR head: f821943f68c6e0b98855de48ab2d800300cc0072
merge base: 3c1547f085507ef14c7375d8717f828aa872e496
target head (main): 9002fe1c0798c2895356b8513d561761ac30ef20
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (5) 
applications
│  ├── nrf_desktop
│  │  ├── configuration
│  │  │  ├── nrf54h20dk_nrf54h20_cpuapp
│  │  │  │  ├── prj.conf
│  │  │  │  ├── prj_dongle.conf
│  │  │  │  ├── prj_release.conf
│  │  │  │  │ prj_release_dongle.conf
│  │  ├── src
│  │  │  ├── modules
│  │  │  │  │ dfu.c

Outputs:

Toolchain

Version: a7529a11f4
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:a7529a11f4_bba2ea5f2e

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 49
  • ✅ Integration tests
    • ✅ desktop52_verification
Disabled integration tests
    • test-fw-nrfconnect-nrf_lrcs_mosh
    • test-fw-nrfconnect-nrf_lrcs_positioning
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread-main
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

Memory footprint analysis revealed the following potential issues

applications.nrf_desktop.zdebug.uart[[email protected]/nrf54h20/cpuapp]: RAM size increased by 785[B] in comparison to the main[3c1547f] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug.uart[[email protected]/nrf54h20/cpuapp]: ROM size increased by 4948[B] in comparison to the main[3c1547f] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug_dongle.uart[[email protected]/nrf54h20/cpuapp]: RAM size increased by 736[B] in comparison to the main[3c1547f] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zdebug_dongle.uart[[email protected]/nrf54h20/cpuapp]: ROM size increased by 4676[B] in comparison to the main[3c1547f] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zrelease[[email protected]/nrf54h20/cpuapp]: RAM size increased by 785[B] in comparison to the main[3c1547f] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zrelease[[email protected]/nrf54h20/cpuapp]: ROM size increased by 2920[B] in comparison to the main[3c1547f] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zrelease_dongle[[email protected]/nrf54h20/cpuapp]: RAM size increased by 736[B] in comparison to the main[3c1547f] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)
applications.nrf_desktop.zrelease_dongle[[email protected]/nrf54h20/cpuapp]: ROM size increased by 2356[B] in comparison to the main[3c1547f] branch. - link (cc: @nrfconnect/ncs-si-bluebagel)

Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-24865/1)

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2025

You can find the documentation preview for this PR here.

MarekPieta
MarekPieta approved these changes Oct 3, 2025
View reviewed changes
applications/nrf_desktop/src/modules/dfu.c
#define PM_ADDRESS_OFFSET (PM_MCUBOOT_PAD_SIZE)
#endif

#define MCUBOOT_PRIMARY_ID PM_MCUBOOT_PRIMARY_ID
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MCUBOOT_PRIMARY_PARTITION_ID? (previously PARTITION word was part of the PM_ prefix)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe MCUBOOT_PRIMARY_SLOT_ID (for consistency with DFU_SLOT_ID)?

applications/nrf_desktop/src/modules/dfu.c
#define MCUBOOT_PRIMARY_ID DT_FIXED_PARTITION_ID(MCUBOOT_PRIMARY_NODE)
#define MCUBOOT_SECONDARY_ID DT_FIXED_PARTITION_ID(MCUBOOT_SECONDARY_NODE)

#if DT_REG_ADDR(CODE_PARTITION_NODE) == DT_REG_ADDR(MCUBOOT_PRIMARY_NODE)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using DT_FIXED_PARTITION_ADDR (to improve readability)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw. It would be good to also test IronSide with our fwupd plugin at some point (to ensure it works there)

applications/nrf_desktop/src/modules/dfu.c
Comment on lines +102 to +103
#define MCUBOOT_PRIMARY_NODE DT_NODELABEL(slot0_partition)
#define MCUBOOT_SECONDARY_NODE DT_NODELABEL(slot1_partition)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could consider checking if both partitions exist (DT_FIXED_PARTITION_EXISTS) and start at different addresses

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarekPieta MarekPieta MarekPieta approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kapi-no @NordicBuilder @MarekPieta