Bugs in find function fixed #46
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Problems and Suggestions
1.1. README.md
There isn't rule for naming functions, variables, folder and files in the repository.
1.2. dataStructures/binaryTree.bat
The
findfunction in dataStructures/binaryTree.bat produces the following error:!test_tree6! was unexpected at this time.The
findfunction returns 1 even if the searched value is in the tree.The
nodevariable is not used in thefindfunction .The
findfunction only searches the first node of the tree.1.3. DateAndTime/DateParts.bat
This script does not work on Windows 10 operating system.
1.4. DateAndTime/W32DOW.bat
The source code isn't documented.
1.5. DateAndTime/W32tmSleep.bat
The source code isn't documented.
1.6. DateAndTime/getTime.bat
The source code isn't documented.
1.7. DateAndTime/sleeptp.bat
The source code isn't documented. The time output format isn't clear.
2. Solutions and Suggestions
2.1. README.md
2.2. dataStructures/binaryTree.bat
Updated
!%1!in find method to%1.The following change was made within the
findfunction:The
nodevariable has been removed from the source code.I haven't developed a solution to this problem yet.
2.3. DateAndTime/DateParts.bat
2.4. DateAndTime/W32DOW.bat
2.5. DateAndTime/W32tmSleep.bat
2.6. DateAndTime/getTime.bat
2.7. DateAndTime/sleeptp.bat
3. Tests
The following scripts edited were run successfully on Windows 10 Pro operating system: