Skip to content

Conversation

@sebetci
Copy link

@sebetci sebetci commented May 25, 2022

1. Problems and Suggestions

1.1. README.md

There isn't rule for naming functions, variables, folder and files in the repository.

1.2. dataStructures/binaryTree.bat

  1. The find function in dataStructures/binaryTree.bat produces the following error: !test_tree6! was unexpected at this time.

  2. The find function returns 1 even if the searched value is in the tree.

  3. The node variable is not used in the find function .

  4. The find function only searches the first node of the tree.

1.3. DateAndTime/DateParts.bat

This script does not work on Windows 10 operating system.

1.4. DateAndTime/W32DOW.bat

The source code isn't documented.

1.5. DateAndTime/W32tmSleep.bat

The source code isn't documented.

1.6. DateAndTime/getTime.bat

The source code isn't documented.

1.7. DateAndTime/sleeptp.bat

The source code isn't documented. The time output format isn't clear.

2. Solutions and Suggestions

2.1. README.md

  • New naming conventions have been added to the README.md file.

2.2. dataStructures/binaryTree.bat

  1. Updated !%1! in find method to %1.

  2. The following change was made within the find function:

:: The second parameter is checked instead of the first parameter.
IF %VTreeName% EQU %2 ( ... )
  1. The node variable has been removed from the source code.

  2. I haven't developed a solution to this problem yet.

2.3. DateAndTime/DateParts.bat

  • This script doesn't work on Windows 10 Pro operating system. Therefore, the script has been updated taking into account the recommendations in the references.
  • The code is documented.
  • New naming conventions applied.

2.4. DateAndTime/W32DOW.bat

  • The code is documented.
  • New naming conventions applied.

2.5. DateAndTime/W32tmSleep.bat

  • The code is documented.
  • New naming conventions applied.

2.6. DateAndTime/getTime.bat

  • Changed the time output to ISO 8601 format.
  • The code is documented.
  • New naming conventions applied.

2.7. DateAndTime/sleeptp.bat

  • The code is documented.
  • New naming conventions applied.

3. Tests

The following scripts edited were run successfully on Windows 10 Pro operating system:

@sebetci sebetci changed the title Bugs in find method fixed Bugs in find function fixed May 25, 2022
@sebetci
Copy link
Author

sebetci commented May 27, 2022

The situation in issue #47 was addressed in this pull request.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant