-
Notifications
You must be signed in to change notification settings - Fork 23
feat: rewrite to make it more extensible #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
3010755
feat: rewrite to make it more extensible
lukekarrys e65214a
chore: use just-diff from json diffing instead
lukekarrys 94e5f26
fix: remove release-next from ci branches
lukekarrys 409cabe
chore: rm unnecessary comment
lukekarrys 0a1bcf1
chore: move json delete logic to template
lukekarrys 41c3e24
feat: add github changelog to release-please
lukekarrys 739ca4b
chore: fix comments
lukekarrys File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,3 @@ | ||
| * @npm/cli-team | ||
| # This file is automatically added by @npmcli/template-oss. Do not edit. | ||
|
|
||
| * @npm/cli-team |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,17 @@ | ||
| # This file is automatically added by @npmcli/template-oss. Do not edit. | ||
|
|
||
| version: 2 | ||
|
|
||
| updates: | ||
| - package-ecosystem: npm | ||
| directory: "/" | ||
| schedule: | ||
| interval: daily | ||
| allow: | ||
| - dependency-type: direct | ||
| versioning-strategy: increase | ||
| commit-message: | ||
| prefix: deps | ||
| prefix-development: chore | ||
| labels: | ||
| - "Dependencies" | ||
| - package-ecosystem: npm | ||
| directory: "/" | ||
| schedule: | ||
| interval: daily | ||
| allow: | ||
| - dependency-type: direct | ||
| versioning-strategy: increase | ||
| commit-message: | ||
| prefix: deps | ||
| prefix-development: chore | ||
| labels: | ||
| - "Dependencies" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,21 +3,40 @@ | |
| name: Audit | ||
|
|
||
| on: | ||
| workflow_dispatch: null | ||
| schedule: | ||
| # "At 01:00 on Monday" https://crontab.guru/#0_1_*_*_1 | ||
| - cron: "0 1 * * 1" | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| audit: | ||
| name: npm audit | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: actions/setup-node@v2 | ||
| - uses: actions/checkout@v3 | ||
| - name: Setup git user | ||
| run: | | ||
| git config --global user.email "[email protected]" | ||
| git config --global user.name "npm cli ops bot" | ||
| - uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: '16' | ||
| - name: Install deps | ||
| run: npm i --package-lock | ||
| - name: Audit | ||
| run: npm audit | ||
| node-version: 16.x | ||
| - name: Update to workable npm (windows) | ||
| # node 12 and 14 ship with npm@6, which is known to fail when updating itself in windows | ||
| if: matrix.platform.os == 'windows-latest' && (startsWith(matrix.node-version, '12') || startsWith(matrix.node-version, '14')) | ||
| run: | | ||
| curl -sO https://registry.npmjs.org/npm/-/npm-7.5.4.tgz | ||
| tar xf npm-7.5.4.tgz | ||
| cd package | ||
| node lib/npm.js install --no-fund --no-audit -g ..\npm-7.5.4.tgz | ||
| cd .. | ||
| rmdir /s /q package | ||
| - name: Update npm to 7 | ||
| # If we do test on npm 10 it needs npm7 | ||
| if: matrix.node-version <= 10 | ||
| run: npm i --prefer-online --no-fund --no-audit -g npm@7 | ||
| - name: Update npm to latest | ||
| if: matrix.node-version > 10 | ||
| run: npm i --prefer-online --no-fund --no-audit -g npm@latest | ||
| - run: npm -v | ||
| - run: npm i --package-lock | ||
| - run: npm audit | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,7 +3,10 @@ | |
| name: CI | ||
|
|
||
| on: | ||
| workflow_dispatch: null | ||
| pull_request: | ||
| branches: | ||
| - '*' | ||
| push: | ||
| branches: | ||
| - main | ||
|
|
@@ -16,37 +19,68 @@ jobs: | |
| lint: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: actions/setup-node@v2 | ||
| - uses: actions/checkout@v3 | ||
| - name: Setup git user | ||
| run: | | ||
| git config --global user.email "[email protected]" | ||
| git config --global user.name "npm cli ops bot" | ||
| - uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: '16' | ||
| - run: npm i --prefer-online -g npm@latest | ||
| node-version: 16.x | ||
| - name: Update to workable npm (windows) | ||
| # node 12 and 14 ship with npm@6, which is known to fail when updating itself in windows | ||
| if: matrix.platform.os == 'windows-latest' && (startsWith(matrix.node-version, '12') || startsWith(matrix.node-version, '14')) | ||
| run: | | ||
| curl -sO https://registry.npmjs.org/npm/-/npm-7.5.4.tgz | ||
| tar xf npm-7.5.4.tgz | ||
| cd package | ||
| node lib/npm.js install --no-fund --no-audit -g ..\npm-7.5.4.tgz | ||
| cd .. | ||
| rmdir /s /q package | ||
| - name: Update npm to 7 | ||
| # If we do test on npm 10 it needs npm7 | ||
| if: matrix.node-version <= 10 | ||
| run: npm i --prefer-online --no-fund --no-audit -g npm@7 | ||
| - name: Update npm to latest | ||
| if: matrix.node-version > 10 | ||
| run: npm i --prefer-online --no-fund --no-audit -g npm@latest | ||
| - run: npm -v | ||
| - run: npm i | ||
| - run: npm run lint | ||
|
|
||
| test: | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| node-version: [12.13.0, 12.x, 14.15.0, 14.x, 16.13.0, 16.x] | ||
| node-version: | ||
| - 12.13.0 | ||
| - 12.x | ||
| - 14.15.0 | ||
| - 14.x | ||
| - 16.0.0 | ||
| - 16.x | ||
| platform: | ||
| - os: ubuntu-latest | ||
| shell: bash | ||
| - os: macos-latest | ||
| shell: bash | ||
| - os: windows-latest | ||
| shell: cmd | ||
| - os: ubuntu-latest | ||
| shell: bash | ||
| - os: macos-latest | ||
| shell: bash | ||
| - os: windows-latest | ||
| shell: cmd | ||
| runs-on: ${{ matrix.platform.os }} | ||
| defaults: | ||
| run: | ||
| shell: ${{ matrix.platform.shell }} | ||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - uses: actions/setup-node@v2 | ||
| - uses: actions/checkout@v3 | ||
| - name: Setup git user | ||
| run: | | ||
| git config --global user.email "[email protected]" | ||
| git config --global user.name "npm cli ops bot" | ||
| - uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| # node 12 and 14 ship with npm@6, which is known to fail when updating itself in windows | ||
| node-version: 16.x | ||
| - name: Update to workable npm (windows) | ||
| # node 12 and 14 ship with npm@6, which is known to fail when updating itself in windows | ||
| if: matrix.platform.os == 'windows-latest' && (startsWith(matrix.node-version, '12') || startsWith(matrix.node-version, '14')) | ||
| run: | | ||
| curl -sO https://registry.npmjs.org/npm/-/npm-7.5.4.tgz | ||
|
|
@@ -55,7 +89,12 @@ jobs: | |
| node lib/npm.js install --no-fund --no-audit -g ..\npm-7.5.4.tgz | ||
| cd .. | ||
| rmdir /s /q package | ||
| - name: Update npm | ||
| - name: Update npm to 7 | ||
| # If we do test on npm 10 it needs npm7 | ||
| if: matrix.node-version <= 10 | ||
| run: npm i --prefer-online --no-fund --no-audit -g npm@7 | ||
| - name: Update npm to latest | ||
| if: matrix.node-version > 10 | ||
| run: npm i --prefer-online --no-fund --no-audit -g npm@latest | ||
| - run: npm -v | ||
| - run: npm i | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,10 +4,14 @@ name: "CodeQL" | |
|
|
||
| on: | ||
| push: | ||
| branches: [ main ] | ||
| branches: | ||
| - main | ||
| - latest | ||
| pull_request: | ||
| # The branches below must be a subset of the branches above | ||
| branches: [ main ] | ||
| branches: | ||
| - main | ||
| - latest | ||
| schedule: | ||
| # "At 03:00 on Monday" https://crontab.guru/#0_3_*_*_1 | ||
| - cron: "0 3 * * 1" | ||
|
|
@@ -24,15 +28,17 @@ jobs: | |
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| language: [ 'javascript' ] | ||
| language: [ javascript ] | ||
|
|
||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v2 | ||
|
|
||
| - name: Initialize CodeQL | ||
| uses: github/codeql-action/init@v1 | ||
| with: | ||
| languages: ${{ matrix.language }} | ||
| - name: Perform CodeQL Analysis | ||
| uses: github/codeql-action/analyze@v1 | ||
| - uses: actions/checkout@v3 | ||
| - name: Setup git user | ||
| run: | | ||
| git config --global user.email "[email protected]" | ||
| git config --global user.name "npm cli ops bot" | ||
| - name: Initialize CodeQL | ||
| uses: github/codeql-action/init@v1 | ||
| with: | ||
| languages: ${{ matrix.language }} | ||
| - name: Perform CodeQL Analysis | ||
| uses: github/codeql-action/analyze@v1 | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.