[ENHANCEMENT] Add 'use strict' directive to cjs files
#774
Comments
|
This is a great idea, and it can be enforced with the eslint |
wraithgar
pushed a commit
that referenced
this issue
May 12, 2025
<!-- What / Why --> <!-- Describe the request in detail. What it does and why it's being changed. --> Adds missing `'use strict'` directives; this directive is dotted around a handful of files in the repo so this PR adds it to the rest of the CJS files. The local eslint file has been updated to enforce this going forward, as suggested in the linked issue. ## References Closes #774 <!-- Examples: Related to #0 Depends on #0 Blocked by #0 Fixes #0 Closes #0 -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It would be beneficial to add the
'use strict'directive to all cjs files in this repo. Strict mode can improve performance by eliminating some JavaScript features that hinder optimizations. It also helps avoid subtle bugs by enforcing more consistent scoping and variable declarations.At present this directive is dotted around a handful of files in the repo.
The MDN article on strict mode alludes to it, but the V8 JS engine used by Node will use more optimised execution paths when strict mode is enabled. See related Stack Overflow discussion for an example.
Happy to make a PR to resolve this.
The text was updated successfully, but these errors were encountered: