Skip to content

Conversation

nlf
Copy link
Contributor

@nlf nlf commented Mar 2, 2021

this is an effort to refactor the testing baseline to something easier to navigate and extend.

yes, it's very verbose, but it makes it extremely clear what inputs are parseable and what are not and adding new test cases is as simple as it can be.

@nlf nlf force-pushed the nlf/refactor-tests branch from 7af589c to 08bca54 Compare March 3, 2021 15:56
@nlf nlf marked this pull request as ready for review March 3, 2021 15:57
@nlf nlf marked this pull request as draft March 3, 2021 17:37
@nlf
Copy link
Contributor Author

nlf commented Mar 3, 2021

converted back to draft because t.match() was not doing what i thought it was so many of these tests are passing but not actually passing. will fix the assertions, fix the tests to match and update this pull request

@nlf nlf force-pushed the nlf/refactor-tests branch from 08bca54 to f89b6fb Compare March 3, 2021 17:51
@nlf nlf marked this pull request as ready for review March 3, 2021 20:29
@nlf nlf mentioned this pull request Mar 3, 2021
@nlf nlf force-pushed the nlf/refactor-tests branch from 8049b7f to c9b2f7d Compare March 3, 2021 20:49
@wraithgar wraithgar self-requested a review March 9, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants