Skip to content

Conversation

thefourtheye
Copy link
Contributor

graceful-fs used to monkey-patch node's core fs module.
This has been fixed in the version 4.

Related: nodejs/node#2714

graceful-fs used to monkey-patch node's core fs module.
This has been fixed in the version 4.
ForbesLindesay added a commit that referenced this pull request Sep 6, 2015
deps: Upgrade graceful-fs dependency to the latest
@ForbesLindesay ForbesLindesay merged commit 8a16ac3 into npm:master Sep 6, 2015
@ForbesLindesay
Copy link
Contributor

Would you like to be added as a collaborator on this project, to help review and merge pull requests?

@thefourtheye thefourtheye deleted the patch-1 branch September 6, 2015 17:31
@thefourtheye
Copy link
Contributor Author

@ForbesLindesay Sure. Thanks :-) Just in case if I have to ping you regarding this repo, what would be your preferred communication channel?

@ForbesLindesay
Copy link
Contributor

Twitter is the best way to ping me if something's urgent or I've been ignoring something. My handle is:

@ForbesLindesay

@ForbesLindesay
Copy link
Contributor

You're added. Please follow these rules:

  1. never commit directly to master unless you're only editing documentation, or you're in the process of cutting a new release.
  2. never merge your own pull request unless it's had no comments from any collaborators for at least 24 hours.
  3. If you cut a new release, make sure you follow semver when updating the version number.

If you let me know your npm username I'll add you as an owner so you can release new versions :)

@ChALkeR ChALkeR mentioned this pull request Feb 5, 2016
cspotcode pushed a commit to cspotcode/cmd-shim that referenced this pull request Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants