Skip to content

Conversation

nlf
Copy link
Contributor

@nlf nlf commented Mar 2, 2022

this was left respecting the workspace due to concerns about configs in the workspaces affecting the command, but configs in workspaces are explicitly ignored unless you disable workspaces entirely so that concern should have no impact here.

References

@nlf nlf requested a review from a team as a code owner March 2, 2022 21:01
@wraithgar wraithgar merged commit 9e43de8 into release-next Mar 2, 2022
@wraithgar wraithgar deleted the nlf/ignore-workspace-in-whoami branch March 2, 2022 21:20
@npm-robot
Copy link
Contributor

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 54.876 ±5.74 31.538 ±0.15 28.742 ±13.90 21.123 ±0.67 3.120 ±0.02 3.161 ±0.00 2.724 ±0.17 12.090 ±0.07 2.513 ±0.04 3.595 ±0.07
#4493 50.082 ±2.14 31.748 ±0.06 29.934 ±16.09 21.923 ±0.96 3.286 ±0.05 3.142 ±0.02 2.602 ±0.04 12.439 ±0.02 2.537 ±0.05 3.732 ±0.11
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 37.048 ±3.12 24.652 ±0.11 13.897 ±0.00 14.782 ±0.45 2.858 ±0.03 2.832 ±0.04 2.495 ±0.05 9.205 ±0.05 2.296 ±0.02 3.325 ±0.10
#4493 39.834 ±1.86 24.508 ±0.11 13.876 ±0.02 15.276 ±0.27 2.874 ±0.03 2.926 ±0.01 2.511 ±0.01 9.345 ±0.07 2.376 ±0.13 3.299 ±0.07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants