chore(config): remove flatOptions references #2892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
force-pushed
the
gar/flatoptions
branch
2 times, most recently
from
754fe69 to
30b8a07
Compare
wraithgar
commented
Mar 17, 2021
wraithgar
commented
Mar 17, 2021
wraithgar
commented
Mar 17, 2021
| const { force, silent, loglevel } = opts | ||
| const force = this.npm.config.get('force') | ||
| const silent = this.npm.config.get('silent') | ||
| const loglevel = this.npm.config.get('loglevel') |
There was a problem hiding this comment.
This was a bug, loglevel is not in flatOptions
wraithgar
force-pushed
the
gar/flatoptions
branch
from
30b8a07 to
5552842
Compare
isaacs
previously requested changes
Mar 17, 2021
darcyclarke
added
the
Release 7.x
ruyadorno
approved these changes
Mar 18, 2021
ruyadorno
added
release: next
Iterative change moving us towards a more unified config. No longer pulling config from flatOptions where we don't have to. PR-URL: #2892 Credit: @wraithgar Close: #2892 Reviewed-by: @ruyadorno
ruyadorno
force-pushed
the
gar/flatoptions
branch
from
52165d6 to
889b06d
Compare
isaacs
pushed a commit
that referenced
this pull request
Mar 18, 2021
Iterative change moving us towards a more unified config. No longer pulling config from flatOptions where we don't have to. PR-URL: #2892 Credit: @wraithgar Close: #2892 Reviewed-by: @ruyadorno
isaacs
pushed a commit
that referenced
this pull request
Mar 18, 2021
Iterative change moving us towards a more unified config. No longer pulling config from flatOptions where we don't have to. PR-URL: #2892 Credit: @wraithgar Close: #2892 Reviewed-by: @ruyadorno
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iterative change moving us towards a more unified config.
No longer pulling config from flatOptions where we don't have to.
This also moves our tests closer to using a real npm instance by having an interim
mockNpmthat acts like npm where we need it to.Closes npm/statusboard#280