pass publishConfig through to npm-registry-fetch #1949
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darcyclarke
added
the
Release 7.x
darcyclarke
pushed a commit
that referenced
this pull request
Oct 12, 2020
PR-URL: https://github.com/Usage: /Users/darcyclarke/.nvm/versions/node/v10.20.1/bin/pull <pull req url> /Users/darcyclarke/.nvm/versions/node/v10.20.1/bin/pull <pull req number> [<remote name>=origin] (will read url/id from clipboard if not specified) Credit: @ Close: #1949 Reviewed-by: @darcyclarke
darcyclarke
pushed a commit
that referenced
this pull request
Oct 12, 2020
PR-URL: https://github.com/Usage: /Users/darcyclarke/.nvm/versions/node/v10.20.1/bin/pull <pull req url> /Users/darcyclarke/.nvm/versions/node/v10.20.1/bin/pull <pull req number> [<remote name>=origin] (will read url/id from clipboard if not specified) Credit: @ruyadorno Close: #1949 Reviewed-by: @darcyclarke
darcyclarke
pushed a commit
that referenced
this pull request
Oct 12, 2020
PR-URL: https://github.com/Usage: /Users/darcyclarke/.nvm/versions/node/v10.20.1/bin/pull <pull req url> /Users/darcyclarke/.nvm/versions/node/v10.20.1/bin/pull <pull req number> [<remote name>=origin] (will read url/id from clipboard if not specified) Credit: @nlf Close: #1949 Reviewed-by: @darcyclarke
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that
publishConfigis passed through to npm-registry-fetch for both publish and unpublish commands, as well as updates npm-registry-fetch to a version that actually cares about that setting.Closes #1937